wrong encoding of quotation-marks

Description

caravan.io.http is using damnhandy-uri-templating which is not encoding urls with quotation-marks. I'm not sure if newer version of this lib will do the right job which would be the prefered way of dealing with this. otherwise the encoding needs to be done at the CaravanHttpRequestBuilder

Activity

Show:
Christoph Walter
July 19, 2017, 2:51 PM

Good point! It was masked within the io.wcm.caravan.packaging.pipeline-hal-client-aem61 why I didn't find it directly. This is the best solution to fix the issue in my opinion.
The faulty handy-uri-template version is bundled within the pipeline-hal-client-aem61 package. I saw that 6.2 was the latest version, 7.0 is not yet released with some additional changes.
@Stefan: Would it be possible to have a 6.3 version with only the handy-uri version switch?

Stefan Seifert
July 19, 2017, 3:19 PM

yes, we can do this - this matches with the existing branch at
https://github.com/wcm-io-caravan/caravan-packaging/tree/java7

i've uploaded a snapshot version here - is this what you expect in the release?
https://oss.sonatype.org/content/repositories/snapshots/io/wcm/caravan/io.wcm.caravan.packaging.pipeline-hal-client-aem61/0.6.3-SNAPSHOT/

Christoph Walter
July 20, 2017, 8:20 AM

At 0.6.3 the version of io.wcm.osgi.wrapper.rxjava changed from 1.0.11-0000 to 1.0.14-0000. Are there other valuable fixes included in this newer version too? Everything else looks perfect.

Stefan Seifert
July 20, 2017, 8:54 AM

yes it makes sense to update this as well - we use it for a long time.

packaging release is done:
http://repo1.maven.org/maven2/io/wcm/caravan/io.wcm.caravan.packaging.pipeline-hal-client-aem61/0.6.4/

Christoph Walter
July 20, 2017, 9:22 AM

Very good.
Thank you very much! I owe you a beer

Fixed

Assignee

Unassigned

Reporter

Christoph Walter

Labels

None

Components

Priority

Major