Config Editor API: Review EditorProperties class

Description

i've renamed EditorNameConstants to EditorProperties to have cleaner API. it should contain only constants that are usable for parameter configuration definitions. all other constants that define properties only used internally by the editor implementation should be moved to a package-private EditorNameConstants inside the impl package. please review the EditorProperties class if some constants should be moved away from it.

please also review the javadoc comments - there are some copy&paste errors.

the PARAMETER_NAME constants does not seem to work if used in a parameter definition? the internal name is still displayed.

Activity

Show:
Stefan Seifert
October 3, 2014, 10:24 PM

thanks

Igor Sechyn
October 3, 2014, 9:44 PM
Edited

fixed in rev db19048:

  • the editor is now using the label property on the parameter as a display name.

  • if the property is not set, the parameter name is used as fallback

Stefan Seifert
October 3, 2014, 2:55 PM

igor:

yes, you are right, however it was not supposed to be used like that. I need to differentiate between the properties, that are used internally to set values like, parameter id, parameter value, locked, inheritance, etc..., and properties that can be used to configure the widgets. I will extract the constants from EditorProperites into EditorNameConstants, which are used internally.

I will also introduce another property PARAMETER_LABEL, which can be used to set the display label for a property in the editor.

Fixed

Assignee

Unassigned

Reporter

Stefan Seifert

Labels

None

Components

Fix versions

Priority

Major