NodeJs Maven Plugin: node_modules and coverage directories

Description

currently we have two global ignores in the wcm.io codebase relating to the nodejs plugin:

  • node_modules

  • coverage

we should try to minimize such global ignores by:

  • try to generate what is possible in the target folder - is this a solution for "coverage"?

  • or include a "." in the folder name because this is common practice to denote "this is an internal folder best not put into your SCM". should we rename "node_modules" to ".node_modules"?

Activity

Show:
Igor Sechyn
October 15, 2014, 4:34 PM
Edited

done. also added to karma maven profile junit and cobertura coverage. junit coverage is under target/surefire-reports/karma-results.xml and cobertura is under target/cobertura

html coverage report is only generated, when run locally under target/coverage

Igor Sechyn
October 15, 2014, 9:33 AM

jep, will take care of it today

Stefan Seifert
October 15, 2014, 9:32 AM

the only issue left is moving the "coverage" directory to the target folder.

Stefan Seifert
October 8, 2014, 1:47 PM

we definitely cannot do this. this name is required by nodejs for resolving the modules

ok, than that folder is defined by nodejs, and not by the plugin. ok we leave it as it is.

i have included this for myself, I can remove this reporter, if we do not need this for any kind of visualization. But I can also move it into the target folder.

yes, please, move it to target. if its related only to frontend rename it to something which makes more clear it has nothing to do with java code coverage.

Igor Sechyn
October 8, 2014, 1:40 PM

or include a "." in the folder name because this is common practice to denote "this is an internal folder best not put into your SCM". should we rename "node_modules" to ".node_modules"?

we definitely cannot do this. this name is required by nodejs for resolving the modules

try to generate what is possible in the target folder - is this a solution for "coverage"?

i have included this for myself, I can remove this reporter, if we do not need this for any kind of visualization. But I can also move it into the target folder.

Fixed

Assignee

Unassigned

Reporter

Stefan Seifert

Labels

None

Components

Fix versions

Priority

Minor