Editor does not display overridden default configuration values

Description

I've noticed that the Editor does not display default parameter values when they are overridden by a ParameterOverrideProvider. This occurs with the OsgiConfigOverrideProvider - I haven't tested any others but looking at the mechanism by which they work I believe this would apply to any ParameterOverrideProvider.

The overridden values are being applied, so when the configuration is actually used the correct value is returned - it's only a problem for the editor as far as I can tell.

I've attached a couple of screenshots to demonstrate, and below is the relevant code snippets:

If I obtain the value, for example in Sightly:

it does return the overridden value: "overridden from osgi".

I believe this stems from io.wcm.config.editor.impl.EditorParameterProvider which provides the overridden value as the "value" rather than the "inheritedValue", even though it's a "default" value according to the override provider.

Activity

Show:
DavidJ
February 5, 2016, 12:51 AM

Good news - that other bug was nothing to do with wcm.io, it was caused by an existing Sling bug which was causing my service.ranking to not be applied correctly: https://issues.apache.org/jira/browse/SLING-2477

DavidJ
February 5, 2016, 12:09 AM

Thanks Stefan, I've just been testing with the latest snapshots and the editor is reporting the overridden defaults correctly now

While testing I did bump into another issue regarding the ranking of override providers but I'll raise a seperate ticket for that once I've collected some more information.

Thanks again!

Stefan Seifert
February 4, 2016, 10:08 PM

rev. 18a28b562d9fce749869b613770f971354df6b1a

should be fixed.
additionally i fixed the handling of "locked" parameters provides via override providers in the editor.

please give it a try with the latest snapshot versions:

snapshot repository is https://oss.sonatype.org/content/repositories/snapshots/

Fixed

Assignee

Unassigned

Reporter

DavidJ

Labels

None

Components

Affects versions

Priority

Major