Inherited collection items for configuration collections with collection inheritance are not stored properly

Description

In the old code, it was the following. If a config page with filled properties. the language pages under this page, will inherit these properties. However, if a property in the language page, which is already inherited should be modified, the author can click on the check box beside it which is called inherited, and uncheck this box, the field becomes editable with the inherited value inside. This was cool "Ziemlich cool". However, in the new editor, this check box that is called inherited cannot be unchecked, which results for a problem for our authors. What is required that it should be like it was before in the old editor wcm.io.config v.0. For more understanding of the problem, please see the attached screenshot.

Activity

Show:
Stefan Seifert
May 2, 2017, 3:24 PM

fine - i plan to release the sling caconfig bundles this week as well

Shady Eltobgy
May 2, 2017, 3:23 PM

Thanks Stefan. I have tested it. Everything is good. Alles tiptop. from my side, this ticket is completely solved.

mfg

shady

Stefan Seifert
May 2, 2017, 2:50 PM

good hint - this issue you mention has to be fixed in sling caconfig - i've created https://issues.apache.org/jira/browse/SLING-6821 for this. it's already you can test it with latest snapshot org.apache.sling.caconfig.impl 1.3.3-SNAPSHOT.

Shady Eltobgy
May 2, 2017, 11:31 AM
Edited

Hey Stefan,

I have tested everything. Almost everything is okay except one problem. Please, consider the follwoing scenario.

1- Delete the node sling:configs under the the path /conf/contextaware-config-sample/sample/sub
2- open the page http://localhost:4502/content/contextaware-config-sample/en/sub-page/config.html#/io.wcm.caconfig.sample.config.ConfigSampleList
3- you find 2 inherited configs, try to update any property in one of them only. then, press save, then load the page again.
Expected: you see two configs, where one of them contains the updated properties.
Actual: you see only the updated config, and not the second one.

Possible solution for this, the property io.wcm.caconfig.editor.config.inheritance.collection that is above should be always checked.

Stefan Seifert
May 2, 2017, 9:02 AM

thanks, looks good to me! i've merged it into develop.

can you give the current editor snapshot 1.2.1-SNAPSHOT a test to ensure it solves your problems as well? then we can prepare a new release soon.

Fixed

Assignee

David Ding

Reporter

Shady Eltobgy

Labels

None

Components

Affects versions

Priority

Major