Configuration editor: Disable add/save buttons when no context path detected

Description

when no context path was detected the add & save buttons should be always disabled.
saving will utterly fail in this case.
perhaps a message should be displayed "No context path detected." instead of the "Context path:".

Activity

Show:
Stefan Seifert
June 3, 2017, 12:07 AM

the "contextPath" property is missing altogether in this case.

steps to reproduce with the sample application:

the correct impl in the branch does not yet handle this (same behavior as before).

David Ding
June 7, 2017, 1:28 AM

steps to reproduce with the sample application:

After doing these steps, http://localhost:4502/content/contextaware-config-sample/en/config/_jcr_content.configNames.json is still requested, and includes "contextPath":"/content/contextaware-config-sample/en/config" in its response.

Is this expected?

Stefan Seifert
June 12, 2017, 10:18 PM

should work - if you removed the property in CRXDE Lite, did you hit the "Save All" button after removing the property?

David Ding
June 22, 2017, 11:22 PM

should work - if you removed the property in CRXDE Lite, did you hit the "Save All" button after removing the property?

I tested again and it does work (i.e. the json does not return a contextPath)

  • and the implementation from 01/Jun/17 works as expected.

I have merged to develop https://github.com/wcm-io/wcm-io-caconfig/commit/f449c4ad9edb9d51e1dcaba1d65c88c23020f35b

Let me know if it is (still) not working for you.

Stefan Seifert
June 23, 2017, 2:57 AM

it works - thanks!
(i've also added an entry to the changelog - changes.xml)

Fixed

Assignee

Unassigned

Reporter

Stefan Seifert

Labels

None

Components

Affects versions

Priority

Major