If the HtmlLilbrary Manager minifies static resources, the Editor App does not work any more

Description

This is a known issue of the angular js framework, which provides three different ways of injecting dependencies and only one of them works, when the code is minified.

The problem can be either solved within the app itself or within the build process. if i recall correctly, there is a grunt task which processes the code accordingly before minifying it.

Activity

Show:
Igor Sechyn
January 14, 2015, 5:06 PM

screw you angular.

the error was caused by the dependency injection within a controller of a directive. the angular error log was not helpful at all. I had to inject the unminified version of the angular library in cq to figure out which service was causing the "circular dependency", as stated in the error log. it turned out it was the $scope service, which was injected as parameter:

and not like:

so it was not really a circular dependency, the minifier replaced the $scope variable by "e" and angular was trying to inject the "e" service.

one should definitely think twice before using angular in a large scale project.

Fixed

Assignee

Unassigned

Reporter

Igor Sechyn

Labels

None

Components

Fix versions

Affects versions

Priority

Major