Multiple editor reloads on a collection configuration breaks the editor

Description

When on any screen that is considered a collection - after 2 page reloads we break the editor

We go from:

to:

Notes:

  • This seems to be caused by the angular app removing the "collection=true" parameter from the configData call the second time around

  • Once this occurs it takes a hard reload of the entire editor to reset this behaviour - navigating away via the home button and back to the affected configuration doesn't solve the issue

Activity

Show:
Stefan Seifert
April 30, 2019, 12:10 AM

thanks! reloading in the same browser window looks fine to me now.

but if a put a deep link e.g.
http://localhost:4502/content/contextaware-config-sample/en/config.html#/io.wcm.caconfig.sample.wcon60.FooterConfig/jcr:content/menu/item1/jcr:content/links
into a new browser window without anything in the cache is get an error "An internal error occured. Please try again".

shouldn't i see the blank page with the link in this case?

David Ding
April 30, 2019, 12:15 AM

but if a put a deep link e.g.
http://localhost:4502/content/contextaware-config-sample/en/config.html#/io.wcm.caconfig.sample.wcon60.FooterConfig/jcr:content/menu/item1/jcr:content/links
into a new browser window without anything in the cache is get an error "An internal error occured. Please try again".

Sorry, I wasn't very clear with my language.

The blank page with just the overview link was what was displayed.
So I decided to automatically redirect to the overview page - since clicking the link and going to the overview page was the only thing the user can do.

But if the the redirect is bad UX, I can remove it.

The error modal is also intentional.
It could be improved with a more specific message, instead of using the generic one.

Stefan Seifert
April 30, 2019, 12:20 AM

ah, ok. yes perhaps a better error message would help in this case - otherwise it just looks broken.
(and there is no indication for an error source, neither on the js console nor in the responses of the backend currently)

David Ding
April 30, 2019, 8:36 PM

Hi - I have created a pull request which adds a specific error message (please in particular review my attempt at a German version) and removes the redirect on error. This way, there is less confusion about what has happened - and the attempted URL remains in the address bar.

https://github.com/wcm-io/wcm-io-caconfig/pull/24/commits/42cd19a5317c4c1a45850520122cdcfab9a1be3c

Stefan Seifert
April 30, 2019, 9:55 PM

thanks, that's fine

Fixed

Assignee

Unassigned

Reporter

Bart Wulteputte

Labels

None

Components

Priority

Major