Projects
/
WHAN-33

ResourceMedia should support responsive image sizes and withs

Description

ResourceMedia should support request attributes for responsive image sizes and withs. This is specially needed when you use a responsive media markup builder.

Also it would be nice to have some kind of generic attribute map to pass custom properties which could be consumed in media processing steps or in the markup builder, e.g. lazy=true

Activity

Show:
Stefan Seifert
January 30, 2020, 4:09 PM

yes, there is currently no syntax for defining map literals in the HTL spec, there is an open issue for it
https://github.com/adobe/htl-spec/issues/63

it would be good to support the picture sources variant as well, probably with a fallback to an array of strings with some special syntax.

Masoud Rozati
January 30, 2020, 7:44 PM

PR updated to support both variants:

  • imageSizes and widthOptions (width + required flag), or

  • pictureSourceMediaFormat, pictureSourceMedia and pictureSourceWidths

 

 

Stefan Seifert
February 10, 2020, 5:26 PM

thanks - looks good! - i've marked some open issues in the PR https://github.com/wcm-io/wcm-io-handler/pull/13

Masoud Rozati
February 19, 2020, 3:17 PM

thanks. changes are made now in a new PR

Stefan Seifert
February 20, 2020, 5:58 PM

thanks! - it's merged

please note i did some cosmetic code cleanup and removed the explicit sort of the widths in the parseWidths method (this was not in place before in MediaComponentPropertyResolver, and i think it's not required but instead the order should be kept as defined as input parameters)

Fixed

Assignee

Stefan Seifert

Reporter

Masoud Rozati

Labels

None

Components

Fix versions

Priority

Major
Configure