Please include com.google.code.gson in aem-dependencies

Description

Please include com.google.code.gson in aem-dependencies, so we do not have to specify the version to import manually.

AEM 6.5.2: 2.8.5

Activity

Show:

Henry Kuijpers April 24, 2020 at 10:45 AM

Errhhh, I can’t close the ticket. Can you do this, please?

Henry Kuijpers April 24, 2020 at 10:45 AM

Indeed, this is now working! Thanks! I’ll close the ticket.

Stefan Seifert April 21, 2020 at 6:44 AM

please note that https://repo1.maven.org/maven2/io/wcm/maven/io.wcm.maven.aem-dependencies/6.5.0.0000/ does not include the gson dependency.
if you are using AEM 6.5.2 use this one:
https://repo1.maven.org/maven2/io/wcm/maven/io.wcm.maven.aem-dependencies/6.5.2.0000/io.wcm.maven.aem-dependencies-6.5.2.0000.pom

which includes the gson dependency.
also, make sure the uber-jar dependency is declared last (or at least after the gson dependency) in your project pom.

does this help?

Henry Kuijpers April 20, 2020 at 7:45 PM

Would this be an issue in my codebase? Anything I'm missing with regards to JsonTreeReader?

The class "DynamicInclude" looks like this:

I believe I'm not doing anything exotic with regards to GSON there?

Henry Kuijpers April 20, 2020 at 7:43 PM

I see, I did a search (through github UI), but couldn't find it. Maybe I was looking in the wrong project.

We're using the a project that was generated from the wcm.io archetype.

In /parent/pom.xml <dependencyManagement>:

In /pom.xml:

In /bundles/commons-core/pom.xml <dependencies>:

This triggers, during the unit tests, an error:

A more detailed stacktrace:

Fixed

Details

Assignee

Reporter

Components

Priority

Created April 20, 2020 at 7:22 PM
Updated April 24, 2020 at 11:10 AM
Resolved April 24, 2020 at 11:10 AM