Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

HttpClientFactory should return a CloseableHttpClient

Description

In advance to the default HttpClient the CloseableHttpClient returns a CloseableHttpResponse which can get auto closed in a try-catch block like

This should reduce errors in dealing with non-closed responses.

Activity

Show:

Stefan Seifert January 3, 2020 at 3:01 PM

thanks - i've updated the PR to add new methods returning CloseableHttpClient interface instead of changing the existing ones. no need to break backward compatibility here, that complicates updating existing apps and systems.

i've also applied the same change to the http async client.

Christoph Nagel January 2, 2020 at 4:41 PM

I’ve created a PR in

Needed to increase package version to 2.0.0

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

Created January 2, 2020 at 4:18 PM
Updated January 31, 2020 at 10:36 PM
Resolved January 3, 2020 at 3:01 PM
Configure