ADD access to request config
Description
Activity
Show:
Christoph Nagel March 8, 2022 at 10:17 AM
Hi Stefan,
I’ve fixed the issues and extended the async HTTP client.
Stefan Seifert March 7, 2022 at 11:48 AM
thanks, i've added feedback to the PR
Christoph Nagel March 4, 2022 at 1:24 PM
I’ve created a PR in
Fixed
Details
Details
Assignee
Reporter
Components
Affects versions
Priority
Created March 4, 2022 at 12:02 PM
Updated March 9, 2022 at 9:47 AM
Resolved March 9, 2022 at 9:47 AM
The
HttpClientFactory
creates an ApacheRequestConfig
(DefaultRequestConfig) from the OSGi config and passes it as default to the ApacheHttpClientBuilder
. When ApacheHttpClient
is returned from factory, there exists no access to the DefaultRequestConfig.It is possible to add a custom
RequestConfig
to the ApacheHttpRequestBase
. But for not defined parameters, it will override the values from the DefaultRequestConfig by default Apache values - hence the settings defined in the OSGi config get lost.Having access to the DefaultRequestConfig, allows to make a copy with custom values by using
RequestConfig#copy
method.Please extend the
HttpClientFactory
by giving access to aRequestConfig
for an url.