Picture tag for DAM rendition is not accordance with W3C validator

Description

Requirement

Generated picture tag with source tags should be accordance with W3C markup validation (validator.w3.org)

Code details

Backend code:

Generated code:

Step to reproduce

1. Add component configured as above.
2. Publish page
3. Copy page markup and paste in W3C validator

Actual behaviour

There are 2 errors

  • Stray end tag source.

  • When the srcset attribute has any image candidate string with a width descriptor, the sizes attribute must also be present.

Activity

Show:
Stefan Seifert
August 19, 2019, 7:49 AM

it's planned within next few days, we're doing some final tests on the other new stuff

Bartlomiej Malecki
August 19, 2019, 7:21 AM

Thank you for resolving issue. When are you planning to release those versions?

 

Stefan Seifert
August 9, 2019, 10:13 PM

this is fixed in Media Handler 1.7.0, Handler Commons 1.3.0 (due to some major works some of it's dependencies need to be updated as well).

the stray source end tag was a bug.

the the "sizes" attribute is mandatory in this case is in my point of view technically not correct. i've ehanced the API so it is possible to define a value for it, so you can set it e.g. to "100vw".

the recommended syntax has changed a bit - example:

Stefan Seifert
August 2, 2019, 1:36 PM

thanks for reporting - i'll have a look at it next week.

Fixed

Assignee

Stefan Seifert

Reporter

Bartlomiej Malecki

Labels

None

Components

Fix versions

Affects versions

Priority

Major