Allow unlimited configuration of the AbsoluteParentContextPathStrategy

Description

We have a use case where CAC configs are basically allowed on all levels (no matter how deeply nested). Currently the configuration property for levels is required though in https://github.com/wcm-io/wcm-io-caconfig/blob/e082419c35983bd5d82c3a8851737f31c2fcef7a/extensions/src/main/java/io/wcm/caconfig/extensions/contextpath/impl/AbsoluteParentContextPathStrategy.java#L68.
It would be nice if there would be support for a configuration which either has no limits at all or only specifies a lower limit (i.e. 1 or 2) but is unlimited below that level.

Activity

Show:

Stefan Seifert February 20, 2019 at 3:25 PM

PR merged

Stefan Seifert January 28, 2019 at 7:59 PM

i've created a PR with my proposal:
https://github.com/wcm-io/wcm-io-caconfig/pull/23

Stefan Seifert January 22, 2019 at 5:45 PM

there is an easy but probably not very elegant workaround: enter all levels with 1..99 into the configuration (assuming 99 is nearly unlimited).

to have proper support and not breaking compatibility with the existing configuration we could add an "unlimited" boolean property to the configuration. if set the given levels are taken into account, and all levels above the given levels as well. i think this could be added without much problems.

Fixed

Details

Assignee

Reporter

Components

Priority

Created January 22, 2019 at 5:01 PM
Updated August 21, 2019 at 8:03 AM
Resolved February 20, 2019 at 3:25 PM