Changes to crx-packmgr-helper is causing the build to fail due to Baseline check
Description
Gliffy Diagrams
Activity
Stefan Seifert April 20, 2017 at 9:16 PM
Trying to investigate and fixing this issue took longer than actually coding the support for Composum.
exactly that's the reason i would suggest switching the one line on pom to "bundle" - nothing is more required and the additional lines in the manifest do not harm.
the maven bundle plugin baseline goal was designed only for osgi bundles, implemeted by the bndlib internally; too much effort to try to analyze why it's not working for non osgi jars. we could disable the baseline check for this pom, but in my pov the benefits of semantic versioning check is higher than avoiding some lines in the manifest making by making it an osgi bundle.
Andreas Schaefer April 20, 2017 at 9:00 PM
Are you suggesting that we migrate the crux-package-manager project to a bundle
just to satisfy the issue with the baseline rather than requiring a fix of the plugin?
Trying to investigate and fixing this issue took longer than actually coding the
support for Composum.
Stefan Seifert April 20, 2017 at 8:30 PM
there seems to be a problem with the baseline check when the packaging type is "jar" - switch it to "bundle" in the pom, then it works.
Andreas Schaefer April 20, 2017 at 3:35 PM
Done but still its not picked up by maven-bundle-plugin. Here are my changes:
https://github.com/headwirecom/wcm-io-tooling/tree/feature/sling
This is what I see now:
[INFO] PACKAGE_NAME DELTA CUR_VER BASE_VER REC_VER WARNINGS
[INFO] = ================================================== ========== ========== ========== ========== ==========
[INFO] * io.wcm.tooling.commons.packmgr minor 0.0.0 0.0.0 0.1.0 Version increase required
[INFO] < class io.wcm.tooling.commons.packmgr.PackageManagerHelper
[INFO] + method executePackageManagerMethodHtml(org.apache.http.impl.client.CloseableHttpClient,org.apache.http.client.methods.HttpRequestBase)
[INFO] + return java.lang.String
[INFO] + version 1.1.0
Stefan Seifert April 20, 2017 at 3:18 PM
if you add new methods or classes you have to increase the 2nd place in the version number (1.1.0) not the third place (1.0.1).
if this does not help - please publish the URL of your fork & branch so i can reproduce the problem.
Details
Details
Assignee
Reporter
Components
Fix versions
Affects versions
Priority
Major
I made some changes to the commons / crx-packmgr-helper module and now the build fails due to an issue raised by the maven-bundle-plugin:baseline.
[INFO] PACKAGE_NAME DELTA CUR_VER BASE_VER REC_VER WARNINGS
[INFO] = ================================================== ========== ========== ========== ========== ==========
[INFO] * io.wcm.tooling.commons.packmgr minor 0.0.0 0.0.0 0.1.0 Version increase required
[INFO] < class io.wcm.tooling.commons.packmgr.PackageManagerHelper
[INFO] + method executePackageManagerMethodHtml(org.apache.http.impl.client.CloseableHttpClient,org.apache.http.client.methods.HttpRequestBase)
[INFO] + return java.lang.String
Looking into the maven-bundle-plugin the baseline should only be executed for Bundles, right?
CRX packmgr helper is used for the maven plugin and therefore not use in a bundle and so it should not test this.